Home Community Mys-Script Creative Off-Topic |
|
|
Thread Tools | Display Modes |
#1
|
|||
|
|||
Opinions and Suggestions (Security issue inside)
First off, I wanted to say that I have worked with several clients using the Rusnak script, and the code in general is just really horrid.
With that said, I have a few things to point out, just from looking over the latest update for 5 minutes. PHP Code:
Also, why is $comment assigned to itself in there? Anyways, next... PHP Code:
PHP Code:
I see this mistake done everywhere, and it is quite a frustrating habit to see other people make. Put quotes in the brackets! Else, it has to check if it is DEFINE'd and what not. Generally bad practice, and it is tremendously slower. Additionally, I believe seeing the encryption was MD5(). Seriously? Not even a salt? Yeah I suppose double MD5 is minorly safer, but that is just silly. MD5 was created in 1991... upgrade much? Also, one last thing. For your major 2.0 release, I highly recommend that you re-do the template system if you can. In fact, a general recommendation is to make the backend object-oriented so it is easier for developers like us to build "mods" and what not. Thanks, NBS Last edited by nobackseat; 02-03-2011 at 03:08 PM. |
|
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Opinions Please | Tequila | Webmasters Area | 10 | 12-13-2012 04:00 PM |
Opinions on Progress | RoconzaArt | Art Gallery | 9 | 01-20-2011 10:38 PM |
Rename adoptables (Security issue fixed!) | kisazeky | Addons/Mods Graveyard | 23 | 10-15-2009 01:14 AM |
What should I code next? Opinions Please! | BMR777 | Other Chat | 29 | 07-14-2008 04:15 AM |
What's New? |
What's Hot? |
What's Popular? |