Major cash glitch

[RoconzaArt]

I found this while setting up my site. If you freeze a pokemon and click on you get money but that's not glitch. If you keep refreshing you keep getting money. All have to do to earn major cash is to camp on the page and keep refresh/pressing F5 to keep earning cash.

I'd really like to see fix for this and will not open until there is some way to resolve this.

[Hall of Famer]

Well you found this eventually...

Yes, this was a glitch from the old Rusnak Adoptables script(my members on pokemansion complained before,sigh), it is also present on MA. I am thinking that the best way to fix this is to remove the freeze option, but maybe not all of you agree with me.

[RoconzaArt]

Well you found this eventually...

Not sure what you mean by that.

I've seen other site build on mys who don't suffer from this problem, Gigi for example after I did some testing. Why not ask her to find out what she knows?

[Hall of Famer]

umm I remember gigi said she got help from professional coders on how to stop people from refreshing or go backward from the current page. This is a nice way of solving problems of cheating, but may not be good as a solution for public script since it may make installation/upgrade process a real pain. A similar problem is with cronjobs. If we code something that requires users to set up cronjobs on their sites, we will lose at least half of customers since they have to manually do this from cpanel(some hosts may not even have cpanel) and it is a pain even for some PHP coders.

An alternative way to solve this problem is to cut out frozen adoptables from displaying on profile.php. Also we can find a way to stop users from clicking on their own frozen adoptables too. Its definitely doable, I will see what can be done. ^^

[fadillzzz]

Why not just prevent the script from giving any cash if the adoptable is frozen?

[Hall of Famer]

Good point Fadillzzz. For now I guess the issue is that in future we will have more than just money reward for clicking on adoptables, so it will be hard to generalize. But yeah, it sounds like a fine solution at this moment.

[Hall of Famer]

The easy fix for this glitch is:

Find the changecash function:

PHP Code:

    changecash(grabanysetting('rewardmoney'), $GLOBALS['username'], $GLOBALS['money']);
    $article_content = $article_content . "<div align='center'><br />You have earned ". grabanysetting('rewardmoney') ." ". grabanysetting('cost') ." for leveling up this adoptable. <br />You now have {$GLOBALS['money']} ".grabanysetting('cost')."</div>"; 


Replace with:

PHP Code:

    if($isfrozen == "no"){   
    changecash(grabanysetting('rewardmoney'), $GLOBALS['username'], $GLOBALS['money']);
    $article_content = $article_content . "<div align='center'><br />You have earned ". grabanysetting('rewardmoney') ." ". grabanysetting('cost') ." for leveling up this adoptable. <br />You now have {$GLOBALS['money']} ".grabanysetting('cost')."</div>";
    } 


This should solve your problem, as it does on my demo site. The glitch will be officially fixed on Mys v1.2.1, sorry about that.

[RoconzaArt]

Thank you so very much Hall of Famer your awesome.

[Hall of Famer]

You are very welcome, Roconza. Glad this problem is resolved, should have done it a long time ago.