Adoptables Shop - Working Again!

[gjac1]

I just found out that if someone was to replace the id in adopt.php?id=xx from the normal adoption page with an id of a shop adoptable, they will get it for free :(

[Haylzee]

Yeah they can, when I made my shop I changed adopt.php to also link to my buy.php (the page that checks your money and removes the amount owing) instead of doadopt.php and just set the prices of the normal adopts to 0. So they still all have to go through the buy.php page but you can still keep 'free' adoptables.

[gjac1]

Originally Posted by Haylzee

Yeah they can, when I made my shop I changed adopt.php to also link to my buy.php (the page that checks your money and removes the amount owing) instead of doadopt.php and just set the prices of the normal adopts to 0. So they still all have to go through the buy.php page but you can still keep 'free' adoptables.

Could you go into this a bit more please ?? :)

I dont have a buy.php :s

[Haylzee]

ETA: After now looking at this mod, I think it's set up differently from mine so what I've put below might not apply.

Ok this is how I set mine up, I have a shop.php which is the same as adopt.php (at the time I had free adoptables and shop adoptables which is why I made them separate, the free adoptables showed up on adopt.php and the ones that cost money showed up on the shop.php). adopt.php uses doadopt.php to put the pets into the owned adoptables table in the database. I made a copy of doadopt.php and called it buy.php, and edited shop.php so that instead of going to doadopt when adopting, it goes to buy.php instead. My buy.php page is coded to check that the user has enough money, if they don't they get told they don't have enough to buy the pet. If they do have enough, the price of the pet gets deducted from their total and the pet goes into their owned adoptables in the database.

Since promo.php still uses adopt.php and doadopt.php, I left it there as normal, but it didn't take long to realize that people could use adopt.php to get free adoptables, so I altered adopt.php to also link to buy.php (basically removing the need for doadopt.php altogether) because now even the free adoptables will still have to go through the process of the money check (which will of course go through because they are set at 0 currency anyway). So even if someone was to use a shop pet id with adopt.php, they will still get charged for it because it's going through the same system.

Of course, this can all be simplified down to just editing doadopt.php to do what buy.php does, but at the time I wanted to keep my doadopt.php unchanged. And I have simplified it a little by charging currency for all the adoptables, none are free. So they all show up on the same page now anyway.

I'm not entirely sure how you have yours set up, but as long as you make sure any adoptions have to go through the money check and money deduction process, no one can get shop adoptables for free.

[gjac1]

I currently have my shop.php directed to use a file called doadopt2.php which i modified myself to add the money checking/deduction process, but that is on shop.php , if a member just does it using the normal adopt.php then they can still get it for free.

[Arianna]

I just looked through your code - how do you have it so if the cash goes under 0, the adoption doesn't work? Some of my members are at -50 coins and stuff, and even though I'm using a different code, it would be greatly appreciated. :)[hr]
Sorry, I got that worked out now. It was a missing '=' in a statement. To think that I spent half an hour tearing my hair out over that...

[Haylzee]

Originally Posted by gjac1

I currently have my shop.php directed to use a file called doadopt2.php which i modified myself to add the money checking/deduction process, but that is on shop.php , if a member just does it using the normal adopt.php then they can still get it for free.

That's because adopt.php is probably still using doadopt.php instead doadopt2.php to add the pets to the database. Your dodoadpt.php, if it hasn't been changed, won't deduct the money, so if someone uses a shop id with adopt.php, the adoption will go through without the deduction process, because that is only happening with doadopt2.php with your deduction code - does that make sense?

Your doadopt2.php is the same as my buy.php - If you edit your adopt.php to use doadopt2.php, it won't matter if people try to use adopt.php to get free adoptables, they won't be able to, because it will still go through the deduction process and deduct the set cost of the adoptable they are trying to get.

In adopt.php find

PHP Code:

<form name='form1' method='get' action='doadopt.php'> 


and just change doadopt.php to doadopt2.php - it's simple enough to change back later if you want. Just remember that promo adoptables still go through adopt.php so this will count for them too. I was using the promo page to give myself shop adoptables for free by just giving them a code, which can no longer be done with adopt.php going through the money process too.

[Arianna]

Why don't you just make it so all adoptables have prices, even if they are 0? That way you don't need any doadopt2's or the like.

[PTGigi]

Originally Posted by gjac1

After spending most of today on this, i have finally figured it out.

After fixing the first few problems i found out that mod wasnt subtracting the cost of the shop item from the current balance, instead it was leaving the user with minus whatever the shop item cost, for example if i had 2000 credits and i bought an adoptable for 500 , it would say my balance was -500 :s , this was due to several things.

Basically all you have to do now is edit the shop.php file and tell it to use doadopt2.php for the actual adoption (search for doadopt.php in shop.php and change it to doadopt2.php) , i have attached my doadopt2.php for you to use with everything fixed.

Thanks again for this original mod, i would never have known where to start making something like this :)

EDIT : oops, it seems i cant attach the file, so i uploaded it here :)

http://www.speedyshare.com/files/19603746/doadopt2.rar

Hey gjac1, is it possible to add that file up again? The site you put it on seems to have deleted it...

[gjac1]

Originally Posted by Arianna

Why don't you just make it so all adoptables have prices, even if they are 0? That way you don't need any doadopt2's or the like.

This is what i ended up doing, but i have to manually change the shop value in myphpadmin to 2 so i can still keep the regular adoptable separate from the shop ones and on different pages.

Thanks for the help :)[hr]
pokemontrainergigi, Here is my doadopt2.php if you still need it :)

http://www.mediafire.com/?5i1qiyvy0mo