Breeding System - Complete!

[Rozel]

Yeah, she said she could not right now. ^^;

[nobackseat]

I realize this is an old post, but I wanted to touch on some of the techniques here, and hope that it will help any other developers.

PHP Code:

$article_content = $article_content."<p>Select 


PHP has the capability built in to append a variable to itself, and it is much easier than reiterating the variable.

PHP Code:

$article_content .= "<p>Select 


Memory resource in this application is tremendous.

There are some simple things here that may seem insignificant, it can make a huge impact.

PHP Code:

$femaleid = $_POST['female'];
$maleid = $_POST['male'];
$breed = $_POST['breed'];

$femaleid = secure($femaleid);
$maleid = secure($maleid);
$breed = secure($breed); 


to

PHP Code:

$femaleid = secure( $_POST[ 'female' ] );
$maleid    = secure( $_POST[ 'male' ] );
$breed     = secure( $_POST[ 'breed' ] ); 


PHP Code:

        $num = mysql_num_rows($result);

        // Loop Out code < this will loop so you select all the rows and not just one
        $i = 0;
        while ($i < $num){ 


to

PHP Code:

// Loop Out code < this will loop so you select all the rows and not just one
$i = 0;
while ( $i < mysql_num_rows( $result ) ) {
} 


This is of course, only if you are using it once, and don't need the $num variable anywhere else.

And lastly,

$i++;

to

++$i;

But that is just me being extremely picky.

The reason for the above is, it is pre-incrementing and it doesn't create a memory reference.

The only difference between the two is, the last one doesn't increment until the end of the string, so in some cases it is not acceptable.

But anyways, yeah. This is not criticizing, I am just offering some tips.

NBS

[Hall of Famer]

Well Arianna has made a new version of Breeding system in this Mys v1.2.0 we are currently developing. I dont see a need to post it atm, but you can assume this one is obsolete.

[elfhome]

I am using this one just to give it a test and I really like it. I can't wait to see the final version in the newest release!